Support 9.4 and 9.5 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +0,0 @@ | |||
| import sys | |||
There was a problem hiding this comment.
Why I removed this: didn't seem to break the build not to have it; and less is more.
There was a problem hiding this comment.
Love that this is not needed anymore. As long as bindgen can run we are good.
solidsnack
force-pushed
the
solidsnack-pg9x
branch
from
49ee215 to
995c79e
Compare
| #include "utils/lsyscache.h" | ||
| #include "replication/output_plugin.h" | ||
| #include "replication/logical.h" | ||
| #include "replication/logical.h" |
There was a problem hiding this comment.
Why do we have this duplicate line?
|
Looking good mostly. I'm curious how we want to test 9.5. Is it enough to test it on osx, and keep 9.4 on linux? |
It's not very much like the real `libpq`, as someone point out on #postgresql.
solidsnack
force-pushed
the
solidsnack-pg9x
branch
from
5176ec8 to
8915fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.