chore(pkg-r): Label all observers and reactives for otel #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
changed the title
schloerke
reviewed
Oct 10, 2025
Comment on lines
+278
to
+279
| last_turn = shiny::reactive(last_turn(), label = "mod_last_turn"), | ||
| last_input = shiny::reactive(last_input(), label = "mod_last_input"), |
There was a problem hiding this comment.
read_only?
Suggested change
| last_turn = shiny::reactive(last_turn(), label = "mod_last_turn"), | |
| last_input = shiny::reactive(last_input(), label = "mod_last_input"), | |
| last_turn = shiny::reactive(last_turn(), label = "last_turn_read_only"), | |
| last_input = shiny::reactive(last_input(), label = "last_input_read_only"), |
There was a problem hiding this comment.
Hmm I was thinking of it like "this is the return value of the module" vs the internal reactive value used in the module. I almost called these return_last_value. But read only works too. I'll ponder
There was a problem hiding this comment.
I'm going to stick with mod_. My take is that if I encountered these labels in an otel trace, having never seen them before, I'd immediately wonder why there's a _read_only version of the two other reactives. Whereas mod_ hopefully signals that it's the value returned by the module.
schloerke
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148