Skip to content

lingering master #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2024
Merged

lingering master #593

merged 1 commit into from
May 20, 2024

Conversation

aronatkins
Copy link
Collaborator

Intent

The rename of master to main prevented S3 pushes of new builds. Discovered while trying to test the recent TensorFlow additions, which were not available through the CDN-hosted builds.

After this change, new main builds will appear on S3.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

git grep master

Automated Tests

Only adjusting GitHub workflow, which is used during CI.

Directions for Reviewers

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

prevented S3 pushes of new builds
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4807 3566 74% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 152defa by action🐍

Copy link
Contributor

@kgartland-rstudio kgartland-rstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aronatkins aronatkins merged commit cee1c85 into main May 20, 2024
15 checks passed
@aronatkins aronatkins deleted the aron-ci-main-not-master branch May 20, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants