deploy/write-manifest tensorflow #589
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
aronatkins
force-pushed
the
aron-tf
branch
2 times, most recently
from
28bc095 to
bea48c2
Compare
| help=( | ||
| "Deploy a TensorFlow model to Posit Connect. Requires Posit Connect 2024.05.0 or later." | ||
| "\n\n" | ||
| "DIRECTORY is the path containing a TensorFlow model." |
There was a problem hiding this comment.
Should DIRECTORY be in all caps here? If this is just a convention I'm unaware of, ignore this.
There was a problem hiding this comment.
The all-caps is a convention we used for Quarto content commands. Its presence feels a little redundant, but folks found it helpful during early testing.
| # check all runtime_environment vars | ||
| single_file_index_file_ans = { |
There was a problem hiding this comment.
What were these tests doing?
There was a problem hiding this comment.
These tests were all trying to confirm that R/Python environment and image fields were retained for static (HTML) content. We do not execute HTML content, so these fields are unnecessary. I removed them as inputs and removed the tests as appropriate.
Intent
Allow manifests/deploys of TensorFlow models.
Fixes https://github.com/rstudio/connect/issues/26884
Type of Change
Approach
Add entrypoints for TensorFlow commands. Removed R/Python/image arguments in situations where they do not apply (e.g. static content).
Automated Tests
Test assembly of manifest and bundle; will add integration tests separately.
Directions for Reviewers
Checklist