Use requirements.txt in docker build #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
aronatkins
approved these changes
Jan 18, 2024
Collaborator
aronatkins
left a comment
aronatkins
left a comment
There was a problem hiding this comment.
I totally missed that we still had a requirements.txt.
nit: The requirements file says:
# This file is just for Snyk scanning,
# because it doesn't understand pyproject.toml
# unless it uses Poetry.
# https://github.com/snyk/snyk-python-plugin/issues/147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR fixes the
make image-*target, which currently fails because the.[test]is not installable within the docker build. Instead, we're usingpip install -r requirements.txt.Type of Change
Automated Tests
This is used in as part of running
make testlocally.Directions for Reviewers