fix: detect virtualenvs on Windows #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mmarchetti
force-pushed
the
ignore-win-env
branch
from
20a9520 to
a9a3ba0
Compare
5 tasks
kgartland-rstudio
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Looks good, we now get a message when virtualenv is detected in Windows and we successfully ignore those folders on deployments.
The warning message thrown doesn't really apply to Windows though, I think that's more about unix systems that have venvs:
Warning: The deployment directory appears to be a python virtual environment.
Excluding the 'bin' and 'lib' directories.
|
The PR failure is due to a breaking change by |
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a variant of #470 that is based on a local branch (CI will not pass on fork branches).