Ensure posix paths in manifest #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that manifest file lists always contain posix paths, and not Windows paths (containing
\
). shinyapps.io does not accept Windows paths in the manifest.json.Intent
Fixes #373
Type of Change
Approach
Using
pathlib.Path.as_posix()
to convert to Posix paths.Automated Tests
I removed all of the special case unit tests for Windows, and make all of the tests run on all platforms.
Directions for Reviewers
Will need to test deployments on posix and Windows clients, deploying to Connect and to shinyapps.io.
Checklist