fix extra files not being included in write-manifest

[bcwu]

Intent

fixes #416

Type of Change

• Bug Fix
• New Feature
• Breaking Change

Approach

Automated Tests

Directions for Reviewers

Checklist

• I have updated CHANGELOG.md to cover notable changes.
• I have updated all related GitHub issues to reflect their current state.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
4192	2649	63%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
rsconnect/main.py	54%	🟢
TOTAL	54%	🟢

updated for commit: 7a46fde by action🐍

[kgartland-rstudio]

I was able to reproduce this on earlier versions of rsconnect-python and it is fixed for Mac on this branch. However, on Windows it still fails with the same error:

> rsconnect version
1.16.1.dev117+g2adcec5

Write manifest command:

> rsconnect write-manifest voila .\voila\ .\voila\test.txt
>>
Checking arguments...                            [OK]
Inspecting Python environment...                 [OK]
    Warning: requirements.txt already exists and will not be overwritten.
Creating manifest.json...                        [ERROR]
Error: Could not find file test.txt under C:\Users\User\voila

file listing:

> ls -l .\voila\


    Directory: C:\Users\User\voila


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----         2/16/2023   7:33 AM                empty-folder
d-----         2/16/2023   7:35 AM                extra-folder
d-----         2/16/2023   7:38 AM                packrat
d-----         2/16/2023   7:41 AM                rsconnect-python
-a----         3/23/2023   8:20 AM      104857600 bigtest
-a----         2/16/2023   7:27 AM            160 environment.yml
-a----         2/16/2023   7:27 AM           8260 index.ipynb
-a----         2/16/2023   7:27 AM           1553 LICENSE
-a----         3/23/2023   8:12 AM        1048576 newtest
-a----         3/24/2023   6:44 AM             49 requirements.txt
-a----         3/23/2023   8:04 AM        1048576 test.txt

[bcwu]

This would be easier to fix with PurePath.is_relative_to, but that is only available in Python 3.9

[kgartland-rstudio]

On the new build, I'm still hitting the same error:

PS C:\Users\User> rsconnect version
1.16.1.dev119+g69411ba

File listing:

PS C:\Users\User> ls .\voila\


    Directory: C:\Users\User\voila


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----         2/16/2023   7:33 AM                empty-folder
d-----         2/16/2023   7:35 AM                extra-folder
d-----         2/16/2023   7:38 AM                packrat
d-----         2/16/2023   7:41 AM                rsconnect-python
-a----         3/23/2023   8:20 AM      104857600 bigtest
-a----         2/16/2023   7:27 AM            160 environment.yml
-a----         2/16/2023   7:27 AM           8260 index.ipynb
-a----         2/16/2023   7:27 AM           1553 LICENSE
-a----         3/23/2023   8:12 AM        1048576 newtest
-a----         3/24/2023   6:44 AM             49 requirements.txt
-a----         3/23/2023   8:04 AM        1048576 test.txt

Write-manifest command:

PS C:\Users\User> rsconnect write-manifest voila .\voila\ .\voila\test.txt
Checking arguments...                            [ERROR]
Error: Could not find file .\voila\test.txt under .\voila

[bcwu]

I am rolling back some of the changes because a Windows fix is larger than the scope of this issue.

[kgartland-rstudio]

On mac/linux, this fix works for APIs and other content when write-manifest requires a directory but when a file is required like in write-manifest notebook... it still fails:

version:

> rsconnect version
1.16.1.dev117+g2adcec5

write-manifest command:

> rsconnect write-manifest notebook stock-report-jupyter/stock-report-jupyter.ipynb stock-report-jupyter/quandl-wiki-tsla.json.gz stock-report-jupyter/testfolder/test.txt --overwrite
Checking arguments...                            [OK]
Inspecting Python environment...                 [OK]
Creating manifest.json...                        [ERROR]
Error: ../quandl-wiki-tsla.json.gz must be under stock-report-jupyter.

It continues to work correctly within the target directory.

[bcwu]

include extra file checklist:

• works from outside the deployment directory
  • Voila
  • Jupyter notebook
  • flask, fastapi. streamlit, dash, bokeh, shiny
  • Quarto
• works from inside the deployment directory (i.e. ./)
  • Voila
  • Jupyter notebook
  • flask, fastapi. streamlit, dash, bokeh, shiny
  • Quarto

[kgartland-rstudio]

Tested all above content types on MacOS with and without extra files ✅
On Windows I ensured write-manifest inside / outside of the target directory continues to work for all content types. ✅