Skip to content

Vetiver tests #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 17, 2023
Merged

Vetiver tests #331

merged 20 commits into from
Jan 17, 2023

Conversation

bcwu
Copy link
Contributor

@bcwu bcwu commented Jan 11, 2023

Description

Adding this as a branch instead of a fork so CI can use secrets.

isabelizimm and others added 18 commits October 13, 2022 15:06
isabelizimm
isabelizimm reviewed Jan 12, 2023
View reviewed changes
@bcwu @isabelizimm
pip install requirements
81997d8 
Co-authored-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>
@bcwu bcwu requested a review from mmarchetti January 13, 2023 22:08
mmarchetti
mmarchetti reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@mmarchetti mmarchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There are some warnings in the Vetiver tests that seem like they should be checked out.

@bcwu bcwu merged commit 6ec75f8 into master Jan 17, 2023
@bcwu bcwu deleted the vetiver-tests branch January 17, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelizimm isabelizimm isabelizimm left review comments

@mmarchetti mmarchetti mmarchetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcwu @mmarchetti @isabelizimm