Skip to content

feat(r): Generic datasources (full PR) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

feat(r): Generic datasources (full PR) #29

wants to merge 14 commits into from
+820 −171

Conversation

schloerke
Copy link
Contributor

Making a PR as I'm getting confused with the branch names. Please feel free to close if the idea is abandoned.

jcheng5 and others added 14 commits April 3, 2025 22:47
@jcheng5
First attempt at genericizing data source
973a433
@jcheng5
Unify prompts by adding chevron Python dependency
8de0ac7
@jcheng5
Make prompt aware of what engine is being used
53c7df3
@jcheng5
Replace SQLite support with SQLAlchemy support
a2122f2
@jcheng5
Don't fail when given table name's case differs from SQLAlchemy Inspe…
a218fb9 
…ctor
@jcheng5
Forgot import
dc0814e
@jcheng5
Have server() return proper class with typed methods, instead of dict
9d95d1d
@jcheng5
Auto-create sqlite database for example
aeb87dd
@jcheng5
Have init() take data frame or sqlalchemy engine directly
c38b567 
...instead of requiring explicit DataSource subclass creation
@jcheng5
Merge remote-tracking branch 'origin/main' into generic-datasource-im…
e7972e8 
…provements

Plus some improvements:
- Cleaner .md file reading code in example apps
- Use GPT-4.1 by default, not GPT-4 😬
- Make sqlalchemy required
@jcheng5
Use GPT-4.1 by default, not GPT-4, yuck
57922b3
@jcheng5
Merge remote-tracking branch 'origin/generic-datasource' into generic…
84d30ad 
…-datasource-improvements
@jcheng5
Update README
a08764b
@npelikan
Optimizing Schema Queries (#26)
43ee050 
* this should significantly speed up schema generation

* another speedup

* ruff formatting

* updating so formatting checks pass
@schloerke
Copy link
Contributor Author

I have looked at resolving the PR conflict. It is beyond a simple fix for querychat.py.
(Not correcting the conflicts as I do not have the correct context.)

@chendaniely
Copy link
Contributor

Some background:

I can maybe copy + paste the changes from #26 into a new pr on the new file locations and that might help? It seems they're speed + SQL query improvements?

@npelikan
Copy link

@chendaniely that sounds good to me!

@chendaniely chendaniely mentioned this pull request Jun 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schloerke @chendaniely @npelikan @jcheng5