Skip to content

Conversation

cpsievert
Copy link
Collaborator

Notice in this example, when clicking on the input suggestion, there is a scrollbar on the input <textarea>

Screenshot 2025-03-06 at 12 04 28 PM

After this change, no more scrollbar:

Screenshot 2025-03-06 at 12 05 30 PM

@cpsievert cpsievert requested a review from gadenbuie March 6, 2025 18:05
@cpsievert
Copy link
Collaborator Author

cpsievert commented Mar 6, 2025

@gadenbuie also note there is a scrollbar on the startup message in that example. Interestingly, it goes away if you remove the padding: 2px in the .suggestion. Any thoughts on how best to get rid of the scrollbar? This would do it

.suggestion {
    padding-left: 2px;
    padding-right: 2px;
}

Update: I decided to just add this in f1351cb

@gadenbuie
Copy link
Collaborator

Notice in this example

which example?

@cpsievert
Copy link
Collaborator Author

Crap, sorry, this one

@cpsievert cpsievert merged commit 1ff586f into main Mar 7, 2025
41 checks passed
@cpsievert cpsievert deleted the fix/textarea-autoresize branch March 7, 2025 03:20
schloerke added a commit that referenced this pull request Mar 10, 2025
* main:
  fix(textarea-autoresize): add a bit of padding when setting textarea height (#1891)
  Properly send custom message in a synchronous manner (#1888)
  fix(page-main-container): Fillable container with min-height/width only when parent layout is fillable (#1885)
  Add `.latest_stream` to `ui.MarkdownStream()` and deprecate `.get_latest_stream_result()` (#1884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants