feat(theme): Branded theming via brand_yml #1743

gadenbuie · 2024-10-22T15:49:18Z

TODO

Add one big kitchen-sink _brand.yml
Add a kitchen sink example app
Add tests

ui.Theme.from_brand() now calls ThemeBrand() directly, but it handles reading the brand from YAML first if needed.

shiny/_main.py

shiny/ui/_theme.py

And rewrite the sass color var resolution for clarity

shiny/ui/_theme_brand.py

SHINY_BRAND_YML_RAISE_UNMAPPED="true" For testing

shiny/ui/_theme.py

shiny/ui/_theme_brand.py

CHANGELOG.md

shiny/ui/_theme_brand.py

Co-authored-by: Carson Sievert <cpsievert1@gmail.com>

…ng them)

gadenbuie added 14 commits October 21, 2024 16:29

feat: initial BrandTheme

f0b3464

feat: rename ThemeBrand

730af5c

feat: Add _brand*.yml to default reload includes

b73470f

feat(Theme): Add from_brand() method

ef936ea

docs: Add brand-yml to interlinks inventories

9ebf4a5

chore: add brand_yml to dev dependencies too

9fe9714

chore(Theme): Rename method _html_dependencies

3943ebc

feat: get fonts dependency from brand.typography

669e08a

chore: clean up code

263ee07

feat: Apply brand.color.palette to bootstrap color map

6035788

fix: Use Bootstrap major version

3184691

chore: Add todo comments

137cc4c

refactor: Move ThemeBrand init code into constructor

949f6f1

ui.Theme.from_brand() now calls ThemeBrand() directly, but it handles reading the brand from YAML first if needed.

feat(ThemeBrand): sanitize color name into valid sass/css variable names

2af0941

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/_main.py Outdated Show resolved Hide resolved

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme.py Outdated Show resolved Hide resolved

refactor: Use brand.color.to_dict() method

03adf5c

And rewrite the sass color var resolution for clarity

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

gadenbuie added 3 commits October 23, 2024 11:41

chore: Apply suggestions from code review

ced644a

refactor: More strongly type sass var maps

409a53b

refactor: Don't version the bootstrap color list

dcf4e32

cpsievert reviewed Oct 23, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

gadenbuie added 3 commits October 23, 2024 12:43

refactor: Consolidate all brand.color sass var logic

948ddce

refactor: Raise ThemeBrandUnmappedFieldError following envvar

142409e

SHINY_BRAND_YML_RAISE_UNMAPPED="true" For testing

chore: Update brand.ya?ml reload includes

048622e

gadenbuie added 11 commits October 24, 2024 22:53

temp: switch to brand_yml from github

fa78936

refactor: brand_yml now handles validation of color.palette names

f7f5605

chore: use _add_defaults_hdr() in additional place

16db15d

refactor: don't use as_css_unit() just work with strings

af8532a

refactor: Call cls from inside class method

04b3011

chore(reload): On yml and yaml changes

d030f8d

refactor: brand_yml handles converting typography.base.size to rem

90b03f5

refactor: simplify finding spec or pkg

5d059e2

chore(examples): Add requirements.txt

f2d35b6

docs: Fill out .from_brand() documentation

83e4a33

docs: small edit

a34e936

cpsievert reviewed Oct 25, 2024

View reviewed changes

shiny/ui/_theme.py Show resolved Hide resolved

cpsievert reviewed Oct 25, 2024

View reviewed changes

shiny/ui/_theme.py Outdated Show resolved Hide resolved

cpsievert reviewed Oct 25, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

gadenbuie added 4 commits October 25, 2024 11:45

chore: slim type

9c9b0da

refactor: BrandBootstrapConfig

439f557

chore: Add changelog item

805aecd

chore: use released brand_yml

65ae093

gadenbuie marked this pull request as ready for review October 25, 2024 16:26

gadenbuie added 2 commits October 25, 2024 12:28

chore: create new dict

bda5054

chore: only import brand for type checking

9b73147

cpsievert reviewed Oct 25, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Update CHANGELOG.md

75dcf2a

cpsievert reviewed Oct 25, 2024

View reviewed changes

shiny/ui/_theme_brand.py Outdated Show resolved Hide resolved

gadenbuie and others added 3 commits October 25, 2024 12:50

Update _theme_brand.py

51dc33b

Co-authored-by: Carson Sievert <cpsievert1@gmail.com>

example: use layout_sidebar() not page_sidebar()

339a9aa

example: pass brand colors along to plotting code (instead of repeati…

edbae14

…ng them)

cpsievert merged commit 1808303 into main Oct 25, 2024
41 checks passed

cpsievert deleted the feat/brand-yml branch October 25, 2024 18:46

gadenbuie mentioned this pull request Nov 7, 2024

chore: Update themes and require Shiny v1.2.0 posit-dev/py-shinyswatch#48

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(theme): Branded theming via brand_yml #1743

feat(theme): Branded theming via brand_yml #1743

Uh oh!

gadenbuie commented Oct 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(theme): Branded theming via brand_yml #1743

feat(theme): Branded theming via brand_yml #1743

Uh oh!

Conversation

gadenbuie commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gadenbuie commented Oct 22, 2024 •

edited

Loading