Draft: Positron INotebookEditor
#9709
Conversation
|
E2E Tests 🚀 |
There was a problem hiding this comment.
I agree with your comments. I think this is a very valuable exploration but probably not worth the effort until we really start hitting edges and then we should figure out which direction we fix (the edges cases or this model).
In looking at the implementation a bit I feel like we may be better off just ripping the bandaid off for some of the wrappers and replacing our custom models with those directly. (Or at least building the satisfaction of the interfaces into the positron model classes.)
| import { IPositronNotebookCell } from '../PositronNotebookCells/IPositronNotebookCell.js'; | ||
| import { PositronCellOutputViewModel } from './PositronCellOutputViewModel.js'; | ||
|
|
||
| export class PositronNotebookCellViewModel extends Disposable implements ICellViewModel { |
There was a problem hiding this comment.
I wonder if we should just refactor the positron notebook cells to fit this rather than wrapping. They are already themselves a wrapper around a cell model.
There was a problem hiding this comment.
I was wondering about this as well, I think I agree
This is a draft PR that implements
INotebookEditor(related to #9440), which opens the door to more easily integrate with many upstream feature implementations (vscode extension API, outlines, cell folding, chat, find, etc).After going through the work, I'm leaning toward closing this PR for now and deferring this until we have a clearer idea of how we want to handle those features and how much that deviates from upstream.
Release Notes
New Features
Bug Fixes
QA Notes