Feat/notebook cell execution info #9026

nstrayer · 2025-08-13T20:02:44Z

Addresses #5495.

@:notebooks

Adds execution information display for notebook cells, showing execution order, duration, and status through a hover popup. The feature includes an execution order badge or status icon in the cell gutter that triggers a detailed popup on hover, providing users with visibility into when cells were executed, how long they took, and their success status. Includes e2e tests covering popup interactions, status changes, and accessibility features.

Release Notes

Bug Fixes

N/A

QA Notes

The e2e tests in test/e2e/tests/notebook/cell-execution-info.test.ts verify all interaction patterns

Manual Testing

Create a new Python notebook and execute cells to verify the execution info appears correctly.

import time
print("Quick execution")

import time
time.sleep(2)
print("Slow execution")

After running these cells, you should see:

Execution order badges (1, 2) appear in the cell gutters
Hover over the badges to see popup with execution duration and timestamp
Status icons during execution (spinning icon while running)
Different styling for successful vs failed executions
Popup auto-closes when mouse leaves the area

github-actions · 2025-08-13T20:03:06Z

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:notebooks

^readme ^{valid tags}

austin3dickey

This is really cool!

I noticed 2 strange-feeling things:

When the hover pops up, the outline of the entire Positron window seems to flash. In my video this is clearest up by the menu bar.
When the hover is onscreen, I can't scroll the notebook. For some reason this subconsciously feels really sticky and annoying 😅

clip.mov

nstrayer · 2025-08-20T18:34:22Z

Ah, this is probably because of my super-heavy handed use of the full positron modal system rather than a more lightweight popup.

nstrayer · 2025-08-21T18:04:18Z

Switched to a new lighterweight "Popover" component for the info... popover. Should be good now.

seeM

Very nice! Sometimes the popover flickers for a frame in the top left of the window:

Screen.Recording.2025-08-22.at.11.27.06.mov

I think the UI details (alignment, choice of text and what we display in the popover, etc) can be refined via mockups and followup PRs.

seeM · 2025-08-22T14:30:04Z

Oh, also not sure how we want to approach Release Notes with Positron NB

… been calculated

nstrayer · 2025-08-22T19:33:09Z

Fixed flicker and removed the release notes

Copilot

Pull Request Overview

This pull request adds a comprehensive cell execution information display feature for Positron notebooks, allowing users to view execution order, duration, timing, and status through an interactive hover popup. The feature enhances the notebook user experience by providing clear visibility into cell execution history and performance metrics.

Adds execution info icon to notebook cells displaying execution order badges or status indicators
Implements detailed hover popup showing execution status, duration, timing, and completion information
Provides responsive status updates during cell execution with visual feedback (spinning icons, status badges)

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/e2e/tests/notebook/positron-notebook-editor.test.ts	Refactors test setup by extracting helper functions to the page object
test/e2e/tests/notebook/cell-execution-info.test.ts	Comprehensive e2e test covering all execution info popup scenarios
test/e2e/pages/notebooksPositron.ts	Adds extensive page object methods for Positron notebook interactions
src/vs/workbench/services/positronNotebook/browser/IPositronNotebookInstance.ts	Updates observable import to use newer module
src/vs/workbench/services/positronNotebook/browser/IPositronNotebookCell.ts	Adds execution timing observables to code cell interface
src/vs/workbench/contrib/positronNotebook/browser/notebookCells/NotebookCodeCell.tsx	Integrates execution info icon component into code cells
src/vs/workbench/contrib/positronNotebook/browser/notebookCells/NotebookCellWrapper.tsx	Adds test identifier for e2e testing
src/vs/workbench/contrib/positronNotebook/browser/notebookCells/NotebookCellWrapper.css	Updates cell styling with margin adjustments and improved animations
src/vs/workbench/contrib/positronNotebook/browser/notebookCells/CellExecutionInfoPopup.tsx	New popup component displaying detailed execution information
src/vs/workbench/contrib/positronNotebook/browser/notebookCells/CellExecutionInfoPopup.css	Styling for the execution info popup with theme support
src/vs/workbench/contrib/positronNotebook/browser/notebookCells/CellExecutionInfoIcon.tsx	New icon component with hover interactions and state management
src/vs/workbench/contrib/positronNotebook/browser/notebookCells/CellExecutionInfoIcon.css	Styling for execution info icons with status-specific appearance
src/vs/workbench/contrib/positronNotebook/browser/PositronNotebookCells/PositronNotebookCodeCell.ts	Backend implementation for tracking execution timing and metadata
src/vs/workbench/contrib/positronNotebook/browser/KernelStatusBadge.tsx	Adds accessibility label for e2e test compatibility
src/vs/workbench/browser/positronComponents/popover/popover.tsx	New reusable popover component with auto-positioning
src/vs/workbench/browser/positronComponents/popover/popover.css	Basic styling for the popover component

Comments suppressed due to low confidence (1)

Copilot · 2025-08-22T19:34:30Z

test/e2e/pages/notebooksPositron.ts

@@ -10,6 +10,7 @@ import { QuickAccess } from './quickaccess';
 import test, { expect, Locator } from '@playwright/test';
 import { HotKeys } from './hotKeys.js';

+const DEFAULT_TIMEOUT = 10000;


[nitpick] Consider making this timeout configurable or using a constant from a shared configuration file to ensure consistency across test suites.

Suggested change

const DEFAULT_TIMEOUT = 10000;

import { DEFAULT_TIMEOUT } from '../config';

Copilot · 2025-08-22T19:34:30Z

src/vs/workbench/contrib/positronNotebook/browser/notebookCells/CellExecutionInfoIcon.tsx

+	cell: PositronNotebookCodeCell;
+}
+
+const POPUP_DELAY = 100;


[nitpick] Consider extracting this magic number to a configuration constant or making it configurable, as hover delays can impact user experience and may need adjustment.

Copilot · 2025-08-22T19:34:31Z

src/vs/workbench/contrib/positronNotebook/browser/notebookCells/CellExecutionInfoPopup.tsx

+							? completedMoreThanAnHourAgo
+								? `${getRelativeTime(lastRunEndTime)} (${formatTimestamp(lastRunEndTime)})`
+								: `${getRelativeTime(lastRunEndTime)}`
+							: ''}


[nitpick] The type narrowing comment should be more descriptive or the code could be restructured to make the type narrowing more explicit without inline comments.

Suggested change

: ''}

{completionTimeText}

Copilot · 2025-08-22T19:34:31Z

src/vs/workbench/browser/positronComponents/popover/popover.tsx

+	anchorElement,
+	onClose,
+	autoCloseOnMouseLeave = true,
+	autoCloseDelay = 100,


[nitpick] Consider extracting magic numbers like this delay to named constants for better maintainability and consistency across the codebase.

Suggested change

autoCloseDelay = 100,

autoCloseDelay = DEFAULT_AUTO_CLOSE_DELAY_MS,

juliasilge · 2025-08-23T02:40:33Z

In terms of release notes, we're not including any public facing release notes until we're ready to invite users to try it out, but I would still encourage folks to outline what a PR does in a single line like we usually do, for ease of navigating.

nstrayer requested review from seeM, austin3dickey and Copilot August 13, 2025 20:02

This comment was marked as outdated.

Sign in to view

nstrayer force-pushed the feat/notebook-cell-execution-info branch from 14a2e04 to 77ab7a4 Compare August 13, 2025 20:08

austin3dickey reviewed Aug 19, 2025

View reviewed changes

nstrayer force-pushed the feat/notebook-cell-execution-info branch from 9066d40 to 4051f4b Compare August 20, 2025 18:37

austin3dickey force-pushed the feat/notebook-cell-execution-info branch from 4051f4b to 9066d40 Compare August 20, 2025 18:51

nstrayer force-pushed the feat/notebook-cell-execution-info branch 2 times, most recently from 070484a to 291c5f6 Compare August 21, 2025 16:11

nstrayer requested review from Copilot and austin3dickey August 21, 2025 18:03

This comment was marked as outdated.

Sign in to view

nstrayer force-pushed the feat/notebook-cell-execution-info branch from c397033 to 158f3f0 Compare August 21, 2025 18:38

seeM reviewed Aug 22, 2025

View reviewed changes

nstrayer added 5 commits August 22, 2025 15:20

Add tests for desired behavior

60ba000

Add new popover component

952ec02

Add cell execution info available on hover

e193241

Remove flicker in top left by not rendering until the positioning has…

41303f8

… been calculated

Reduce delay to make things feel snappier

dfc9973

nstrayer force-pushed the feat/notebook-cell-execution-info branch from 158f3f0 to dfc9973 Compare August 22, 2025 19:32

nstrayer requested review from seeM and Copilot August 22, 2025 19:33

Copilot AI reviewed Aug 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/notebook cell execution info #9026

Feat/notebook cell execution info #9026

nstrayer commented Aug 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

austin3dickey left a comment •

edited

Loading

Uh oh!

nstrayer commented Aug 20, 2025

Uh oh!

nstrayer commented Aug 21, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

seeM left a comment

Uh oh!

seeM commented Aug 22, 2025

Uh oh!

nstrayer commented Aug 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 22, 2025

Uh oh!

Copilot AI Aug 22, 2025

Uh oh!

Copilot AI Aug 22, 2025

Uh oh!

Copilot AI Aug 22, 2025

Uh oh!

juliasilge commented Aug 23, 2025

Uh oh!

Uh oh!

	const DEFAULT_TIMEOUT = 10000;
	import { DEFAULT_TIMEOUT } from '../config';

	autoCloseDelay = 100,
	autoCloseDelay = DEFAULT_AUTO_CLOSE_DELAY_MS,

Feat/notebook cell execution info #9026

Are you sure you want to change the base?

Feat/notebook cell execution info #9026

Conversation

nstrayer commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

Bug Fixes

QA Notes

Manual Testing

Uh oh!

github-actions bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

austin3dickey left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nstrayer commented Aug 20, 2025

Uh oh!

nstrayer commented Aug 21, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

seeM left a comment

Choose a reason for hiding this comment

Uh oh!

seeM commented Aug 22, 2025

Uh oh!

nstrayer commented Aug 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

juliasilge commented Aug 23, 2025

Uh oh!

Uh oh!

nstrayer commented Aug 13, 2025 •

edited

Loading

github-actions bot commented Aug 13, 2025 •

edited

Loading

austin3dickey left a comment •

edited

Loading