new python folder: update language #8223
Conversation
|
E2E Tests 🚀 |
austin3dickey
force-pushed
the
aus/reword
branch
from
c64de11 to
cd92a62
Compare
| // --- Start Positron --- | ||
| // export const providerDescription = l10n.t('Creates a `.venv` virtual environment in the current workspace'); | ||
| export const providerDescription = l10n.t('Create a new ".venv" environment with an existing interpreter'); | ||
| // --- End Positron --- |
There was a problem hiding this comment.
This does change the Python: Create Environment... command's descriptions too, but I think it's still clear what's happening there
|
e2e tests are failing just because they're looking for specific text, so I'll wait for feedback on this text before fixing them! |
| @@ -522,7 +530,9 @@ export namespace CreateEnv { | |||
|
|
|||
| // --- Start Positron --- | |||
| export namespace Uv { | |||
| export const providerDescription = l10n.t('Creates a `uv` virtual environment in the current workspace'); | |||
| export const providerDescription = l10n.t( | |||
| 'Install a new interpreter with uv and create a new ".venv" environment', | |||
There was a problem hiding this comment.
Does this always install a new Python interpreter, or will it use my .local ones if available?
There was a problem hiding this comment.
Maybe:
'Select an interpreter or if necessary install with uv and create a new ".venv" environment',
There was a problem hiding this comment.
I think this is a tiny bit confusing in terms of the OR AND precedence. Is this accurate?
'Select an interpreter or (if needed) install with uv, and then create a new ".venv" environment',
There was a problem hiding this comment.
I played with a LOT of different wordings and like this the best. I think it's both precise and clear.
austin3dickey
force-pushed
the
aus/reword
branch
from
cd92a62 to
3293fbb
Compare
|
The remaining failing test is unrelated. |
Addresses part of #8040.
Slight modifications of the language used in the Python step of the New Folder Flow for clarity.
Defaults:
New dropdown:
If you select venv:
If you select "use existing":
Release Notes
New Features
Bug Fixes
QA Notes
@:new-folder-flow
Just click around these menus; behavior should not be changed