Skip to content

Add configurable scipen bias setting for number formatting in Data Explorer #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kv9898
Copy link
Contributor

@kv9898 kv9898 commented Apr 15, 2025

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

@juliasilge
Copy link
Contributor

Thank you once again for contributing to Positron, @kv9898! 🙌 It has been so exciting to see the ways in which you have been able to improve the experience of working in the IDE.

Unfortunately, we are not wanting to address #4818 with the approach in this PR, i.e. formatting the values from the front end using a user-defined IDE setting. We want to go in a direction where we respect the formatting options set inside the kernel (e.g. R's digits and scipen options). I know it's disappointing to hear something like this, and I'm sorry that we're not able to accept his PR. 😔

If you are interested in working on this problem from a different approach, I can point you to some PRs in ark that work on some related ideas:

To get the value of an option from inside ark, check out how we use harp::get_option().

@kv9898
Copy link
Contributor Author

kv9898 commented Apr 28, 2025

@juliasilge Thanks for the explanation! Nevertheless, I don't think they are contradictory, though. There are cases where no 'kernal' setting is available at all. For example, when the user opens a csv/xlsx file directly in the data explorer.

I personally think it would be nice if we could respect the kernal setting while keeping a fall-back option for when no kernal is involved, like what this PR does. After all, this PR does not make implementing the kernal-based logic more difficult. :)

Also, from my understanding, accommodating scipen for kernals is not in a near milestone, and it will likely be done on a kernal-by-kernal basis. This implies a long wait, during which the user may use thr setting provided by this PR as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Explorer - scientific notation - does not adhere to options(scipen = xxx)
2 participants