e2e-test: update session tests #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
There was a problem hiding this comment.
PR Overview
This PR updates session tests to accommodate the removal of the power button by streamlining session management and test logic. Key changes include the addition of a deleteDisconnectedSessions function, a refactor of reuseSessionIfExists to simplify session reuse behavior, and updates in the tests to use these new methods.
Reviewed Changes
| File | Description |
|---|---|
| test/e2e/pages/sessions.ts | Added deleteDisconnectedSessions and refactored reuseSessionIfExists; improved getMetadata step message. |
| test/e2e/tests/sessions/sessions.test.ts | Removed skip directive and updated tests to leverage the new session management methods. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/e2e/pages/sessions.ts:242
- The updated reuseSessionIfExists method no longer explicitly handles the 'disconnected' status (previously triggering a different flow), which may change the intended behavior for disconnected sessions. Please verify that falling back to a full launch for all non-idle sessions is correct.
async reuseSessionIfExists(session: SessionInfo): Promise<string> {
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sessions tests broke when the power button was removed. Updated tests to be able to handle this.
QA Notes
@:sessions