Add validation support for connections drivers by dfalbel · Pull Request #11582 · posit-dev/positron

dfalbel · 2026-01-28T20:01:12Z

Summary

Adds connection validation support, allowing drivers to return validation errors that are displayed inline in the connection modal with an animated error overlay.

Release Notes

New Features

Added validation support for connection drivers with inline error display

Bug Fixes

N/A

QA Notes

@:connections

Open the Connections pane and click "New Connection"
Select BigQuery (Application Default Credentials)
Clear the Project ID field and observe the error message appears
Enter a valid project ID and verify the error clears
Test the Service Account driver similarly with the keyfile path

github-actions · 2026-01-28T20:01:30Z

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:connections

^readme ^{valid tags}

Update generateCode to return {valid, code, errorMessage} for validation. When project ID is empty, the Connect button is disabled and shows a red border on the code editor to indicate an error state. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Display validation errors at the bottom of the code editor as an overlay with a grow-up animation. Removed previous box-shadow approach in favor of an absolutely positioned message element. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replace { valid: boolean; code: string; errorMessage?: string } with string | { code: string; errorMessage: string }. A string return indicates valid code, while the object form indicates validation failure with an error message. This removes the redundant valid field. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Prevents long error messages from breaking the layout by truncating with ellipsis. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Use vscode.l10n.t() for all user-facing error messages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Copilot

Pull request overview

This PR adds validation support for connection drivers, enabling drivers to return validation errors that are displayed inline in the connection modal dialog with an animated error overlay. The implementation extends the generateCode method to optionally return an object containing both code and an error message, which triggers visual feedback and disables the Connect button.

Changes:

Extended the generateCode interface to support returning validation errors alongside code
Updated UI to display validation errors with an animated overlay and disable the Connect button when errors are present
Implemented validation for BigQuery drivers to check for required Project ID field

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/vs/workbench/services/positronConnections/common/interfaces/positronConnectionsDriver.ts`	Updated `generateCode` return type to support error messages
`src/vs/workbench/contrib/positronConnections/browser/components/newConnectionModalDialog/createConnectionState.tsx`	Added state management for validation errors, updated button styling and disabled state
`src/vs/workbench/contrib/positronConnections/browser/components/newConnectionModalDialog/createConnectionState.css`	Added error message styling with animation and adjusted footer button layout
`src/vs/workbench/api/common/positron/extHost.positron.protocol.ts`	Updated protocol interface for validation support
`src/positron-dts/positron.d.ts`	Updated public API type definitions
`extensions/positron-connections/src/drivers/bigquery.ts`	Implemented validation for Project ID in both BigQuery drivers

extensions/positron-connections/src/drivers/bigquery.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Daniel Falbel <dfalbel@gmail.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

dhruvisompura

I had a few comments about the code but the changes work as described!

The animation to show the error message is really slick. You could consider adding a similar transition when the error message disappears.

...ib/positronConnections/browser/components/newConnectionModalDialog/createConnectionState.tsx

Co-authored-by: Dhruvi Sompura <dhruvi.sompura@posit.co> Signed-off-by: Daniel Falbel <dfalbel@gmail.com>

The MainThreadDriverAdapter was using getters for generateCode, connect, etc. which created new function references on every access. This caused React's useEffect to re-run continuously since generateCode was in its dependency array. Changed to create stable function references once in the constructor. Also fixed Form component to: - Pass inputs state instead of metadata.inputs - Use immutable updates instead of mutating input objects Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replace keyframe animation with CSS transitions so the error banner animates both on entry and exit. The element is now always in the DOM but hidden via transform/opacity, allowing CSS transitions to handle both directions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

dhruvisompura

This is looking amazing! 🚀

I have one very small nit left but feel free to merge this once that is resolved. It shouldn't need a re-review!

dhruvisompura · 2026-02-04T01:23:25Z

...ib/positronConnections/browser/components/newConnectionModalDialog/createConnectionState.tsx

-	const editorOptions = useMemo(() => ({
+	const editorOptions: IEditorOptions = {
 		readOnly: true,
 		cursorBlinking: 'solid' as const


small nit: I don't think you need the as const here anymore now that this is typed!

dfalbel changed the title ~~Add BigQuery connection driver with validation support~~ Add validation support for connections drivers Jan 28, 2026

dfalbel mentioned this pull request Jan 28, 2026

Add BigQuery connection driver for Python #11566

Merged

dfalbel and others added 6 commits January 28, 2026 17:06

Use box-shadow for error indicator to prevent layout shift

f409a75

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add text overflow handling to error message overlay

7356d73

Prevents long error messages from breaking the layout by truncating with ellipsis. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Localize error messages in BigQuery driver

25df4ab

Use vscode.l10n.t() for all user-facing error messages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

dfalbel force-pushed the feature/bigquery-connection-validation branch from f7dc530 to 25df4ab Compare January 28, 2026 20:06

This was referenced Jan 28, 2026

Connection modal should indicate required vs optional fields #11584

Open

Add Redshift connection drivers for Python #11534

Merged

dfalbel requested a review from Copilot January 28, 2026 20:32

Copilot started reviewing on behalf of dfalbel January 28, 2026 20:32 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

extensions/positron-connections/src/drivers/bigquery.ts Show resolved Hide resolved

extensions/positron-connections/src/drivers/bigquery.ts Show resolved Hide resolved

dfalbel and others added 3 commits January 29, 2026 08:03

Apply suggestions from code review

82ea0b8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Daniel Falbel <dfalbel@gmail.com>

Add error icon to connection validation error banner

5f2440e

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add generateCode API documentation with examples

d6f56ca

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

dfalbel marked this pull request as ready for review January 30, 2026 17:32

dfalbel requested a review from dhruvisompura January 30, 2026 17:33

dhruvisompura reviewed Feb 2, 2026

View reviewed changes

dfalbel and others added 4 commits February 3, 2026 09:46

Apply suggestions from code review

9f452b9

Co-authored-by: Dhruvi Sompura <dhruvi.sompura@posit.co> Signed-off-by: Daniel Falbel <dfalbel@gmail.com>

use Icon component

055c6ab

dfalbel requested a review from dhruvisompura February 3, 2026 14:47

dhruvisompura approved these changes Feb 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add validation support for connections drivers#11582

Add validation support for connections drivers#11582
dfalbel wants to merge 13 commits intomainfrom
feature/bigquery-connection-validation

dfalbel commented Jan 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

dhruvisompura left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhruvisompura left a comment

Uh oh!

dhruvisompura Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dfalbel commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release Notes

New Features

Bug Fixes

QA Notes

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

dhruvisompura left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhruvisompura left a comment

Choose a reason for hiding this comment

Uh oh!

dhruvisompura Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dfalbel commented Jan 28, 2026 •

edited

Loading

github-actions bot commented Jan 28, 2026 •

edited

Loading