Running arm64 REH build exits with MODULE_NOT_FOUND error

[timtmok]

System details:

Positron and OS details:

main on Linux arm64 and Mac

Interpreter details:

n/a

Describe the issue:

I haven't been able to try this on Linux x86_64 but a local REH build fails to run from what looks like import problems from the 1.95.0 merge.

../vscode-reh-web-darwin-arm64/bin/positron-server --version
node:internal/modules/cjs/loader:1225
  const err = new Error(message);
              ^

Error: Cannot find module '../package.json'
Require stack:
- /Users/tmok/source/vscode-reh-web-darwin-arm64/out/server-main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at file:///Users/tmok/source/vscode-reh-web-darwin-arm64/out/server-main.js:59132:12
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:123:5) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/tmok/source/vscode-reh-web-darwin-arm64/out/server-main.js'
  ]
}

Node.js v20.18.0
(base) 

Steps to reproduce the issue:

1. Build REH. (I used npm run gulp vscode-reh-web-darwin-arm64 and npm run vscode-reh-web-linux-arm64)
2. Run positron-server

Expected or desired behavior:

No errors about finding modules

Were there any error messages in the UI, Output panel, or Developer Tools console?

[timtmok]

I just ran this in Docker while emulating x86_64 and it worked.

#8 [4/4] RUN /vscode-reh-linux-x64/bin/positron-server --version
#8 1.045 Positron: 2025.01.0 build 95
#8 1.045 Positron SHA: 1df88e1c4acc0739ccf1b51a85ea5ff10058ea79
#8 1.045 Code OSS: 1.95.0
#8 1.045 Arch: x64
#8 DONE 1.1s

[jmcphers]

This is where the error is being raised, from server-main.js:

var pkgObj = { BUILD_INSERT_PACKAGE_CONFIGURATION: "BUILD_INSERT_PACKAGE_CONFIGURATION" };
if (pkgObj["BUILD_INSERT_PACKAGE_CONFIGURATION"]) {
  pkgObj = require3("../package.json");
}

This source is compiled from bootstrap-meta here:

positron/src/bootstrap-meta.ts

Lines 16 to 19 in 460beec

	let pkgObj = { BUILD_INSERT_PACKAGE_CONFIGURATION: 'BUILD_INSERT_PACKAGE_CONFIGURATION' }; // DO NOT MODIFY, PATCHED DURING BUILD
	if (pkgObj['BUILD_INSERT_PACKAGE_CONFIGURATION']) {
	pkgObj = require('../package.json'); // Running out of sources
	}

[jmcphers]

There's build tooling that is supposed to insert the package.json contents inline.

positron/build/lib/inlineMeta.ts

Lines 26 to 36 in 460beec

	export function inlineMeta(result: NodeJS.ReadWriteStream, ctx: IInlineMetaContext): NodeJS.ReadWriteStream {
	return result.pipe(es.through(function (file: File) {
	if (matchesFile(file, ctx)) {
	let content = file.contents.toString();
	let markerFound = false;
	const packageMarker = `${packageJsonMarkerId}:"${packageJsonMarkerId}"`; // this needs to be the format after esbuild has processed the file (e.g. double quotes)
	if (content.includes(packageMarker)) {
	content = content.replace(packageMarker, JSON.stringify(JSON.parse(ctx.packageJsonFn())).slice(1, -1) /* trim braces */);
	markerFound = true;
	}

However, it isn't running or isn't working, as the working version also has this placeholder. The difference between the working version (Linux) and the broken one (macOS) is the presence of package.json in the build folder.

[jmcphers]

Note that this fix went into the 2025.01 branch so should be verified on the next 2025.01 build.

[timtmok]

Everything is working again!

tmok@tmok-ubuntu24:~/source/vscode-reh-web-linux-arm64/bin$ ./positron-server --version
Positron: 2025.02.0 build 127
Positron SHA: ff251d5c9766025e32ce58706e757dfc7d2fc9bc
Code OSS: 1.96.0
Arch: arm64