R: Duplicated entries in completions

[strengejacke]

System details:

Positron and OS details:

Positron Version: 2025.01.0 (system setup) build 39
Code - OSS Version: 1.93.0
Commit: c7ef34f
Date: 2024-12-09T02:44:40.379Z
Electron: 30.4.0
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.26100

Interpreter details:

R 4.4.2

Describe the issue:

Steps to reproduce the issue:

I started Positron and typed easystats:: into the console, and the tooltip for auto-completion contained duplicated entries. After restarting the console, issue disappears.

Were there any error messages in the UI, Output panel, or Developer Tools console?

R Kernel

024-12-12 08:42:01.817 [info] ** Begin kernel log for session R 4.4.2 (r-36eff0a2) at 12/12/2024, 8:42:01 AM **
2024-12-12 08:42:01.817 [info] Streaming kernel log file: C:\Users\DL\AppData\Local\Temp\kernel-27y1AK\kernel.log
[R]   2024-12-12T07:42:03.957088Z ERROR  Error receiving internal Help message: RecvError
[R]     at crates\ark\src\help\r_help.rs:127
[R] 

Positron R extension

2024-12-12 08:41:54.977 [info] Log level: Debug
2024-12-12 08:41:54.977 [info] Refreshing testthat status
2024-12-12 08:41:55.215 [info] Testthat test explorer enabled for 'ggeffects' at 'c:\Users\DL\Documents\GitHub\strengejacke\ggeffects'
2024-12-12 08:41:56.054 [info] found testthat.R
2024-12-12 08:41:56.371 [info] found 1 test files
2024-12-12 08:41:56.371 [info] Context key 'testthatIsConfigured' is 'true'
2024-12-12 08:41:56.371 [info] Context key 'testthatHasTests' is 'true'
2024-12-12 08:42:00.781 [info] Registry key HKEY_LOCAL_MACHINE\SOFTWARE\R-core\R64\InstallPath reports the current R installation is at C:\Program Files\R\R-4.4.2
2024-12-12 08:42:00.782 [info] Identified the current R binary: C:\Program Files\R\R-4.4.2\bin\x64\R.exe
2024-12-12 08:42:00.785 [info] Candidate R binary at C:\Program Files\R\R-4.4.2\bin\x64\R.exe
2024-12-12 08:42:00.785 [info] R installation discovered: {
  "valid": true,
  "supported": true,
  "binpath": "C:\\Program Files\\R\\R-4.4.2\\bin\\x64\\R.exe",
  "homepath": "C:\\Program Files\\R\\R-4.4.2",
  "semVersion": {
    "options": {},
    "loose": false,
    "includePrerelease": false,
    "raw": "4.4.2",
    "major": 4,
    "minor": 4,
    "patch": 2,
    "prerelease": [],
    "build": [],
    "version": "4.4.2"
  },
  "version": "4.4.2",
  "arch": "x86_64",
  "current": true,
  "orthogonal": true
}
2024-12-12 08:42:00.909 [info] Registry key HKEY_LOCAL_MACHINE\SOFTWARE\R-core\R64\4.4.2\InstallPath reports an R installation at C:\Program Files\R\R-4.4.2
2024-12-12 08:42:01.970 [info] Candidate R binary at C:\Program Files\R\R-4.4.2\bin\x64\R.exe
2024-12-12 08:42:01.971 [info] R installation discovered: {
  "valid": true,
  "supported": true,
  "binpath": "C:\\Program Files\\R\\R-4.4.2\\bin\\x64\\R.exe",
  "homepath": "C:\\Program Files\\R\\R-4.4.2",
  "semVersion": {
    "options": {},
    "loose": false,
    "includePrerelease": false,
    "raw": "4.4.2",
    "major": 4,
    "minor": 4,
    "patch": 2,
    "prerelease": [],
    "build": [],
    "version": "4.4.2"
  },
  "version": "4.4.2",
  "arch": "x86_64",
  "current": true,
  "orthogonal": true
}
2024-12-12 08:42:03.773 [info] Creating Positron R 4.4.2 language client (port 53474)
2024-12-12 08:42:03.773 [info] ARK (R 4.4.2) language client state changed uninitialized => starting
2024-12-12 08:42:03.969 [info] Creating Positron R 4.4.2 language client (port 52222)
2024-12-12 08:42:03.969 [info] ARK (R 4.4.2) language client state changed starting => starting
2024-12-12 08:42:04.094 [info] ARK (R 4.4.2) language client init successful
2024-12-12 08:42:04.094 [info] ARK (R 4.4.2) language client state changed starting => running

Positron Language Server

4-Positron Language Server R 4.4.2 (console).log

[ntluong95]

It happened once for me. But I think if you restart the IDE, it will be gone

[strengejacke]

Ok, have to check if I can replicate this issue. You say it might be it only happens once after fresh installation? (I just updated to the latest positron on my laptop)

[juliasilge]

This is intermittent, but I can reproduce it at times:

I believe I am seeing this only if it is the very first thing I attempt to do in Positron, but once it starts duplicating it continues to do so.

[juliasilge]

I'm running into this pretty frequently now; I think it must be a fairly recent regression:

[strengejacke]

Yes, can't remember I saw it that often in older versions, too

[juliasilge]

This happened to me today and I paired with @DavisVaughan to get some more details.

• provide_completions() is being called twice in the kernel
• Only one ark is running
• LSP logs show two CompletionParams messages but one CompletionResolve
• Console logs show two Positron LSP servers started on two different ports

A Positron window behaving correctly with single completions has one LSP server, provide_completions() called once, etc.

The message in the LSP logs is generated here, in startLsp():

positron/extensions/positron-r/src/session.ts

Line 676 in dba8a8c

this._kernel.emitJupyterLog(`Starting Positron LSP server on port ${port}`);

I actually feel somewhat hopeful now that #5727 fixes this problem; note that #5714 that this PR fixes is a very similar intermittent problem. I will be using a build with this PR integrated in it today, to see if I continue to see any double completions.

[juliasilge]

Unfortunately, this problem showed up in a test run last night on main, which definitely already has #5727 incorporated.

Looks like we do not yet have this fixed. 😩

cc @midleman @testlabauto