Skip to content

Commit

Permalink
Omit Shiny from bootstrapped extensions (#6562)
Browse files Browse the repository at this point in the history
The Shiny extension 1.1.2 is missing a macOS binary, which is causing
builds to fail when we try to bundle it.

```
[VSCode-darwin-universal/Positron.app/Contents/Resources/app/extensions/bootstrap/posit.shiny-1.1.2.vsix]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of VSCode-darwin-universal/Positron.app/Contents/Resources/app/extensions/bootstrap/posit.shiny-1.1.2.vsix or
        VSCode-darwin-universal/Positron.app/Contents/Resources/app/extensions/bootstrap/posit.shiny-1.1.2.vsix.zip, and cannot find VSCode-darwin-universal/Positron.app/Contents/Resources/app/extensions/bootstrap/posit.shiny-1.1.2.vsix.ZIP, period.
```

We shouldn't even be trying to bundle the Shiny extension for MacOS; it
is happening because the mechanism for selecting extensions for
inclusion in Workbench vs. Desktop needs to be reworked (this change
also removes the existing mechanism).

The fix here is just to remove the extension from the set of
bootstrapped extensions. I'll open a separate issue to add it back for
Workbench.
  • Loading branch information
jmcphers authored Mar 1, 2025
1 parent d111c2f commit af2946d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 27 deletions.
7 changes: 0 additions & 7 deletions build/lib/bootstrapExtensions.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions build/lib/bootstrapExtensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,6 @@ export function getBootstrapExtensions(): Promise<void> {
const controlState = control[extension.name] || 'marketplace';
control[extension.name] = controlState;

// Discard extensions intended for the web. The 'type' field isn't a
// formal part of the extension definition but a custom field we use to
// filter out web-only extensions (i.e. Posit Workbench)
// @ts-ignore
if (extension.type === 'reh-web') {
continue;
}

streams.push(syncExtension(extension, controlState));
}

Expand Down
12 changes: 0 additions & 12 deletions product.json
Original file line number Diff line number Diff line change
Expand Up @@ -233,18 +233,6 @@
},
"publisherDisplayName": "Posit Software, PBC"
},
{
"name": "posit.shiny",
"version": "1.1.2",
"repo": "http://github.com/posit-dev/shiny-vscode",
"type": "reh-web",
"metadata": {
"id": "f1b3b3b4-3b3b-4b3b-8b3b-3b3b3b3b3b3b",
"publisherId": "090804ff-7eb2-4fbd-bb61-583e34f2b070",
"displayName": "Shiny",
"multiPlatformServiceUrl": "https://open-vsx.org/api"
}
},
{
"name": "quarto.quarto",
"version": "1.118.0",
Expand Down

0 comments on commit af2946d

Please sign in to comment.