feat: extend content.get() to automatically use include param
#420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
cgraham-rs
changed the title
include paraminclude param
tdstein
requested changes
Jul 8, 2025
Collaborator
tdstein
left a comment
tdstein
left a comment
There was a problem hiding this comment.
Looks like the integration test is failing for some older versions of Connect.
tdstein
reviewed
Jul 8, 2025
Comment on lines
34
to
36
| assert "owner" in item | ||
| assert "tags" not in item | ||
| assert "vanity_url" not in item |
Collaborator
There was a problem hiding this comment.
Yeah, looks like this was introduced in 2024.06.0. You can key these tests off of https://github.com/posit-dev/posit-sdk-py/blob/main/integration/tests/posit/connect/__init__.py#L8
Collaborator
There was a problem hiding this comment.
Something like...
if CONNECT_VERSION >= version.parse("2024.06.0"):
assert "owner" in item
assert "tags" not in item
assert "vanity_url" not in item
tdstein
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
includeparam support forcontent.get()Replaces previous fork PR: #416