feat: add method to retrieve active bundle #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an active() method to the Bundles class to retrieve the currently active bundle, resolving issue #380.
- Added unit tests in tests/posit/connect/test_bundles.py for scenarios when an active bundle exists and when it does not.
- Implemented the active() method in src/posit/connect/bundles.py with proper documentation.
- Extended integration tests in integration/tests/posit/connect/test_bundles.py to validate bundle activation behavior.
- Updated the workflow file (.github/workflows/site.yaml) with minor adjustments to build commands.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/posit/connect/test_bundles.py | Added unit tests for new active() method behavior |
| src/posit/connect/bundles.py | Introduced active() method with documentation |
| integration/tests/posit/connect/test_bundles.py | Added integration tests for bundle activation functionality |
| .github/workflows/site.yaml | Minor adjustment to build command indentation in workflow |
Collaborator
Author
|
I did a side quest using Claude Code. |
jonkeane
reviewed
May 1, 2025
jonkeane
reviewed
May 1, 2025
jonkeane
approved these changes
May 2, 2025
Collaborator
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this! I do appreciate that the operative code is small and we're adding test cases for places we lacked some before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
active()method toBundlesclass to retrieve the currently active bundle.Resolves #380