feat: Add support for AWS integration content session token exchange #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
zackverham
reviewed
Mar 21, 2025
zackverham
reviewed
Mar 21, 2025
zackverham
reviewed
Mar 21, 2025
zackverham
reviewed
Mar 21, 2025
zackverham
approved these changes
Mar 21, 2025
Collaborator
zackverham
left a comment
zackverham
left a comment
There was a problem hiding this comment.
Couple of tiny observations / nits, but the overall pattern matches what we've done previously so I think this looks great.
Probably will want Taylor to give it a lookover as well just to make sure he doesn't see anything I missed.
tdstein
reviewed
Mar 21, 2025
2 tasks
tdstein
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to existing helper for Viewer integrations but the content session token counterpart.
Usage example in docstring for function.
Tests updated.