Skip to content

Conversation

@mconflitti-pbc
Copy link
Collaborator

  • Refactored supported token types into a string enum
  • Added aws creds helper to properly decode the value from the Connect credential exchange endpoint

@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1857 1747 94% 0% 🟢

New Files

File Coverage Status
src/posit/connect/external/aws.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
src/posit/connect/client.py 99% 🟢
src/posit/connect/oauth/oauth.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 6049ee6 by action🐍

Copy link
Collaborator

@zackverham zackverham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks reasonable to me!

Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mconflitti-pbc mconflitti-pbc merged commit a41b81d into main Mar 14, 2025
38 checks passed
@mconflitti-pbc mconflitti-pbc deleted the add-requested-token-type branch March 14, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants