Skip to content

Conversation

@tdstein
Copy link
Collaborator

@tdstein tdstein commented Feb 24, 2025

All requests sent over HTTP to Connect are responded to with a redirect to the HTTPS location. By default, Requests follows the default HTTP specification and removes the POST body when redirecting. We want to override this behavior to ensure the POST body is carried through the redirect.

Resolves #385

@github-actions
Copy link

github-actions bot commented Feb 24, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1839 1729 94% 0% 🟢

New Files

File Coverage Status
src/posit/connect/sessions.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
src/posit/connect/client.py 99% 🟢
TOTAL 99% 🟢

updated for commit: 7b488cd by action🐍

Co-authored-by: Barret Schloerke <barret@posit.co>
@tdstein tdstein merged commit 2d77ba3 into main Feb 28, 2025
37 checks passed
@tdstein tdstein deleted the tdstein/385-forward-3xx-bodies branch February 28, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: forward POST body with 3xx redirection statues

4 participants