feat: deprecates field access by attribute. #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdstein
force-pushed
the
tdstein/262-remove-resource-properties
branch
from
9561465 to
53ffe59
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
force-pushed
the
tdstein/uv-tooling
branch
from
e98e0f2 to
e54e32f
Compare
tdstein
force-pushed
the
tdstein/262-remove-resource-properties
branch
from
53ffe59 to
beabe6c
Compare
toph-allen
approved these changes
Sep 9, 2024
Collaborator
toph-allen
left a comment
toph-allen
left a comment
There was a problem hiding this comment.
How does this relate to #271 in terms of scheduling / release?
Collaborator
Author
Removes all @Property annotated methods used for direct field access on concrete resources. A new __getattr__ implementation is added to Resource to maintain backwards compatiblity. This implementation calls __getitem__ when the key exists in self. A noisy deprecation warning is issued to alert users that this functionality will be removed in v1.0.0.
tdstein
force-pushed
the
tdstein/262-remove-resource-properties
branch
from
beabe6c to
4f3098d
Compare
Collaborator
Author
|
@zackverham, this includes changes to the OAuth resources you added yesterday. |
zackverham
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all
@propertyannotated methods used for direct field access on concrete resources. To maintain backward compatibility, a new__getattr__implementation is added to Resource. This implementation invokes__getitem__when the key exists in self. A noisy deprecation warning alerts users that this functionality will be removed in v1.0.0.