Skip to content

Include otelsdk to usage-metrics-dashboard#329

Draft
marcosnav wants to merge 1 commit intomainfrom
mnv-usage-mdash-otelsdk
Draft

Include otelsdk to usage-metrics-dashboard#329
marcosnav wants to merge 1 commit intomainfrom
mnv-usage-mdash-otelsdk

Conversation

@marcosnav
Copy link
Contributor

WIP, needs a couple checks:

  1. Does the renv.lock look good?
  2. manifest.json needs to be updated

"Repositories": [
{
"Name": "CRAN",
"URL": "https://packagemanager.posit.co/cran/latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that the URL should stay as posit.co

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think this URL should stay as-is. It's safe to just back out this change manually if you want.

@marcosnav
Copy link
Contributor Author

@karawoo I'd love your input on this one, a couple things:

  1. in order to include the otelsdk package, I had to add library(otelsdk) to the app file for renv to pick it up, even though we are not explicitly using it in the app but the package is a requirement for Shiny to write traces. Is this the right thing to do?
  2. I also wanted to update the Shiny version of this app. For that, I removed anything related to renv first, then did renv::init() to pick up the updated version of Shiny (and otelsdk). Is this the right thing to do? Seems the Repositories.URL was renamed to https://packagemanager.posit.co/cran/latest while doing so.

@karawoo
Copy link
Contributor

karawoo commented Feb 20, 2026

  1. in order to include the otelsdk package, I had to add library(otelsdk) to the app file for renv to pick it up, even though we are not explicitly using it in the app but the package is a requirement for Shiny to write traces. Is this the right thing to do?

yes, this is what I'd do

  1. I also wanted to update the Shiny version of this app. For that, I removed anything related to renv first, then did renv::init() to pick up the updated version of Shiny (and otelsdk). Is this the right thing to do? Seems the Repositories.URL was renamed to https://packagemanager.posit.co/cran/latest while doing so.

This works and is fine, assuming the app works with all the versions of the packages that you've snapshotted. Probably the easier way to is to leave the existing renv.lock file in place and do renv::update(packages = "shiny"). That will update shiny (and possibly also packages shiny depends on). Your way works too, it just results in more changes to the lockfile because you may have different versions of other packages that are now showing up as changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants