Skip to content

Make Ark's stdout behaviour consistent with Python #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −7
Closed

Make Ark's stdout behaviour consistent with Python #962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions crates/ark/src/interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,13 +1882,7 @@ impl RMain {
Stream::Stderr
};

// If active execution request is silent don't broadcast
// any output
if let Some(ref req) = r_main.active_request {
if req.request.silent {
return;
}
}
// No early return for silent requests anymore to match Python kernel behaviour.

if stream == Stream::Stdout && is_auto_printing() {
// If we are at top-level, we're handling visible output auto-printed by
Expand Down
Loading