Export LSP utils crate for Ark #452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll avoid exposing TS in public aether APIs unless strictly needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares Ark taking a dependency on functionality (currently) provided by Air.
Move
from_proto::andto_proto::conversion utils to a newaether_lsp_utilscrate. "aether" is our tentative name for the set of products having to do with language analysis.Some reorganisation of exported parser tools. Was mostly meant to support exporting a version of the parser that takes a TS tree instead of text source, but we decided not to introduce TS in the public API, at least for now. The long term plan is to remove any TS-based functionality and we'll try to respect that along the way.
New
from_proto::apply_text_changes()helper extracted fromDocument::update(). Takes aVec<lsp_types::TextDocumentContentChangeEvent>and updates a source.New
apply_text_edits()which takes aVec<lsp_types::TextEdit>and updates a source. Handles change ordering a little differently asapply_text_changes(), see comments inline.