Skip dist clean in esbuild watch mode#24
Merged
Conversation
wch
approved these changes
Jul 23, 2026
Collaborator
|
Thanks for the fix! I merged in some stuff in to main here too early and this fixes some of the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The esbuild config deletes
dist/and the tsbuildinfo files at startup so one-shot builds start clean. In watch mode this is a problem: the esbuild script starts at the same time as the twotsc --emitDeclarationOnly --watchprocesses, with no guaranteed ordering. If a tsc watcher finishes its first emit before thermSyncruns, the clean wipes out the.d.tsfiles it just wrote. Because tsc's watch mode only re-emits when source changes (not when outputs go missing), those declarations never come back until you touch a source file.This change only runs the clean for one-shot builds and skips it in watch mode. It also adds
tsconfig.positron.tsbuildinfoto the one-shot clean list so both declaration builds start fresh.