Add missing connection env mappings and AWS profile shaping#21
Merged
Conversation
SNOWFLAKE_ACCOUNT and SNOWFLAKE_HOME were mapped but SNOWFLAKE_HOST was not, even though snowflake.host is part of the config schema and the Positron auth reader already treats it as the preferred host input for private-link/RCR endpoints.
wch
approved these changes
Jul 22, 2026
wch
left a comment
wch
left a comment
Collaborator
There was a problem hiding this comment.
Just one comment, but otherwise looks good.
Also, just a reminder for future reference that when Assistant pulls in this change, it will need to be updated.
Comment on lines
+58
to
+61
| /** AWS region (`authentication.aws.credentials.AWS_REGION`, env on the bridge side). */ | ||
| getAwsRegion(): string | undefined; | ||
| /** AWS profile, from the resolved catalog's `connection.aws.profile`. */ | ||
| getAwsProfile(): string | undefined; |
Collaborator
There was a problem hiding this comment.
I think it would make sense to combine these into a single getAws(): { region?: string; profile?: string } | undefined. This would match the shape of ResolvedConnection.aws from https://github.com/posit-dev/ai-lib/blob/eab5a4e58/packages/ai-config/src/types.ts#L126, and it would also be more like getSnowflake(), where there's a single function call to get info for the provider.
Matches the shape of ResolvedConnection.aws and the getSnowflake() pattern of one call per provider.
melissa-barca
force-pushed
the
14710-connection-env-mappings
branch
from
July 22, 2026 14:59
ff957db to
df8002f
Compare
melissa-barca
enabled auto-merge (squash)
July 22, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
ai-config/ai-credentialsin sync with functionality Positron already has, ahead of the provider catalog migration (posit-dev/positron#14710).Adds support for configuring Snowflake via
SNOWFLAKE_ACCOUNT,SNOWFLAKE_HOST, andSNOWFLAKE_HOME, and GEAP viaGOOGLE_VERTEX_BASE_URL,GOOGLE_VERTEX_PROJECT, andGOOGLE_VERTEX_LOCATION(the latter two as a fallback whenGOOGLE_CLOUD_PROJECT/GOOGLE_CLOUD_LOCATIONare unset). Also adds a configured AWS profile to credential shaping, and removes the settings-backed credential config default (callers now inject the config factory).Removing
createVscodeCredentialConfigis safe and necessary due to the addition ofgetAwsProfile(): its only consumer, Posit Assistant, has supplied its own credential config since posit-dev/assistant#1707, leaving this one reachable only from ai-lib's tests.Closes #18