Conversation
stschiff
reviewed
Dec 9, 2025
Member
stschiff
left a comment
There was a problem hiding this comment.
OK, that's definitely already fine as suggested here. Just some points that I'm thinking about:
In the YAML, I think I may actually prefer a hierarchical encoding, so:
- licence:
- short_name: CC-BY-4.0
- file: LICENCE.TXT
which I think we can encode through our levels in the POSEIDON_yml_fields.tsv, right?
I also would suggest to be more explicit that the file is more optional than the short name. I think it would lower the barrier to use licenses if one can just plug in a short name without having to find the text on the internet and copy it here.
Member
Author
|
Good point! I'll implement that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it was @martynamolak who proposed this initially and I think it is a good feature to have. I tried to make it pretty flexible and, of course, fully optional.
The british spelling of "licence" nauseates me a bit, but I guess we should stick to it for consistency.