Resize ioctl #126
Merged
Resize ioctl #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sulakshm
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Now I see what you meant yesterday. Given the IOCtl interface is tested and working, any reasons other requests from userspace go through fuseIO instead of IOCtl?
For this issue the changes look good... so porx pxdriver will use IOCtl to submit this instead of doing a write on fuse control dev.
sulakshm
reviewed
Jun 6, 2020
sulakshm
requested changes
Jun 6, 2020
sulakshm
approved these changes
Jun 8, 2020
prabirpaul
added a commit
that referenced
this pull request
Jun 18, 2020
prabirpaul
added a commit
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow resize operation to be called from outside of px-storage. When resizing, revalidate_disk could be a long running operation. If px dies while the op is in progress, px-storage ends up in D state.