PB-8347: Fix KDMP Backup Failure in-case KDMP job removed post VB CR is updated with SnapshotID #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OSS Scan Results:
Total issues: 142 |
|
License Evaluation Results:
Total License Issues: 17 |
sgajawada-px
requested review from
lalat-das,
prashanthpx,
siva-portworx,
px-kesavan and
pallav-px
vikasit12
reviewed
Oct 30, 2024
| @@ -607,7 +607,7 @@ func UpdateResourceBackupStatus( | |||
| } | |||
|
|
|||
| // CreateVolumeBackup creates volumebackup CRD | |||
| func CreateVolumeBackup(name, namespace, repository, blName, blNamespace string) error { | |||
| func CreateVolumeBackup(name, namespace, repository, blName, blNamespace string) (bool, error) { | |||
There was a problem hiding this comment.
Is it necessary to change function signature?
Can't simply return nil if snaphotID is already there.
if volumeBackup.Status.SnapshotID != "" { // If SnapshotID exists, return early or handle accordingly return nil } // Proceed with the rest of the logic if SnapshotID does not exist
There was a problem hiding this comment.
If we return nil, then will go with the control flow and takes another snapshot (redoing the same work again). So instead will return from the runBackup to prevent taking another snapshot.
vikasit12
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
- Update CreateVolumeBackup to return a boolean based upon the snapshotID
- Update KopiaBackup runBackup to exit successfully in case the VB CR already holds the snapshotID
Which issue(s) this PR fixes (optional)
Closes #PB-8347
Special notes for your reviewer:
PFA of Testing Screenshots