fix(coredns): dns resolution fix#102
Merged
stevensbkang merged 8 commits intodevelopfrom Feb 23, 2026
Merged
Conversation
stevensbkang
requested review from
Copilot
and removed request for
deviantony
There was a problem hiding this comment.
Pull request overview
This PR implements DNS resolution improvements for the kubesolo Kubernetes distribution. The changes ensure that CoreDNS can properly resolve external DNS queries by using valid upstream nameservers, fixing potential issues in environments where the host's /etc/resolv.conf contains loopback or link-local addresses.
Changes:
- Updated kubelet to use a validated or auto-generated resolv.conf for container DNS resolution
- Added DNS policy and wait logic for CoreDNS pod readiness
- Improved CoreDNS configuration with loop detection and updated forwarding and caching behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/runtime/network/ip.go | Added GetHostResolvConf function to find or generate a valid resolv.conf with global unicast nameservers, following k3s approach |
| pkg/kubernetes/kubelet/config.go | Changed kubelet to use GetHostResolvConf instead of hardcoded /etc/resolv.conf path |
| pkg/components/coredns/deployment.go | Added DNSPolicy: DNSDefault to CoreDNS pod spec to use node's DNS configuration |
| pkg/components/coredns/coredns.go | Added waitForCoreDNSReady function to ensure CoreDNS is ready before returning from Deploy |
| pkg/components/coredns/configuration.go | Updated CoreDNS Corefile: added loop detection, changed forward to use /etc/resolv.conf, enabled caching for cluster.local success responses, reordered plugins |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stevensbkang
changed the title
stevensbkang
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.