Fix #33: Move macros to a dedicated object. #34
Merged
+73
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready to be reviewed and merged 🎉 |
sjrd
requested changes
Mar 2, 2021
Contributor
sjrd
left a comment
sjrd
left a comment
There was a problem hiding this comment.
I have a few comments.
Also, I have migrated the master branch to GitHub Actions, so please rebase this PR on top of the latest master to get the latest CI.
sideeffffect
force-pushed
the
without-scala-reflect
branch
from
a693b83 to
24ab8b1
Compare
Contributor
Author
|
@sjrd the build is green 🎉 |
Contributor
Author
|
@sjrd do you think you could merge this PR and make a release, please? 🙏 |
sjrd
changed the title
sjrd
requested changes
Mar 3, 2021
Contributor
sjrd
left a comment
sjrd
left a comment
There was a problem hiding this comment.
LGTM. Could you squash into a single commit with a clean commit message that starts with Fix #33: , e.g.,
Fix #33: Move macros to a dedicated object.
24ab8b1 to
7496cc0
Compare
sideeffffect
force-pushed
the
without-scala-reflect
branch
from
7496cc0 to
8015c05
Compare
Contributor
Author
|
Of course! Squashed 👍 |
sjrd
approved these changes
Mar 3, 2021
Contributor
Author
|
Could somebody please also make a release containing this fix? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixes #33
/cc @sjrd @neko-kai @keynmol @adamgfraser