Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .scrutinizer #239

Merged
merged 4 commits into from
Jun 15, 2018
Merged

Create .scrutinizer #239

merged 4 commits into from
Jun 15, 2018

Conversation

farribeiro
Copy link
Contributor

@farribeiro farribeiro commented Jun 13, 2018

Link #236

Closes #233

Thanks @williamespindola

.scrutinizer.yml Outdated
@@ -0,0 +1,19 @@
filter:
excluded_paths:
- tests/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faltou o que foi citado no code review do outro PR.

Copy link
Contributor Author

@farribeiro farribeiro Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faltou o que foi citado no code review do outro PR.

Este é o commit original do @williamespindola e não contempla outras sugestões

Fabio Rodrigues Ribeiro added 2 commits June 13, 2018 20:47
Copy link
Contributor

@williamespindola williamespindola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apenas remove a linha 3 - tests/*

.scrutinizer.yml Outdated
@@ -0,0 +1,21 @@
filter:
excluded_paths:
- tests/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remova - tests/*

.scrutinizer.yml Outdated
excluded_paths:
- tests/*
- 'ieducar/tests/*'
- 'ieducar/misc/**/*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta aqui @MarceloCajueiro

@farribeiro
Copy link
Contributor Author

Infelizmente mesmo com estes excludes mal muda o score do Scrutinizer

@MarceloCajueiro
Copy link
Contributor

Tks!

@MarceloCajueiro MarceloCajueiro merged commit da8e138 into portabilis:master Jun 15, 2018
@farribeiro farribeiro deleted the scrutinizer branch June 15, 2018 12:43
@farribeiro farribeiro self-assigned this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants