Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cohort.get_sequencing_groups in cpg_workflows targets.py #899

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EddieLF
Copy link
Contributor

@EddieLF EddieLF commented Sep 11, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.39%. Comparing base (3d7b16c) to head (9bebd60).

Files with missing lines Patch % Lines
cpg_workflows/targets.py 60.86% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   78.50%   77.39%   -1.12%     
==========================================
  Files          10       10              
  Lines        1791     1809      +18     
==========================================
- Hits         1406     1400       -6     
- Misses        385      409      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattWellie
Copy link
Contributor

I think this is also close-able WRT #959, which guts all crossover between Cohorts and Datasets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants