-
Notifications
You must be signed in to change notification settings - Fork 1
Expose parsed docker images #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
EddieLF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
(We don't have a CODEOWNERS file in this repository yet, but to be clear: @populationgenomics/software-team will also review this before it should be merged.) |
|
BTW do you have a draft PR somewhere showing how you want to use this API? |
Not exactly, we have a quirky situation where
So assuming we're using version Outside of that specific workflow context it feels like a good move to enable access to the currently private objects that have done all the heavy lifting of contacting the images API. The dictionary is populated but contains no public access points, so we can't even check if a given tag exists using this interface, it all requires foreknowledge of tags. |
Adds a public method to sit on top of the existing artifactory parsing code, allowing a user to view the available tags for a project-location-repository-image combination. The
_repo_image_tagsremains a private variable, but we now have a 'public' method to expose all tags for a known image.Additional: alteration to types in DockerImage