Compress sequencing_groups job attribute when it is very large #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add _pack_attribute() to compress attribute values if necessary. Suppress annoying ruff warnings about "incomprehensible" numeric constants. Pop 'sequencing_groups' from the incoming attributes as we may not replace the existing item later. Retain `or []` to continue to guard against the unlikely event of the raw incoming value being None rather than [].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production-pipelines etc workflows generator-side implementation for SET-565.
Add
_pack_attribute()to compress attribute values if necessary. (Suppress annoying ruff warnings about "incomprehensible" numeric constants.)Pop
'sequencing_groups'from the incoming attributes as we may not replace the existing item later. Retainor []to continue to guard against the unlikely event of the raw incoming value being None rather than[].This compresses
sequencing_groups(and is flexible enough for other attributes in future if necessary) for transport through the Hail database to the billing aggregator. populationgenomics/cpg-infrastructure#308 processes anysequencing_groups_gzipattributes it sees, and should be merged and deployed before this PR.