Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR contains multiple maintenance updates to ensure compatibility with the latest CPG-Flow version and improve file organization. The changes address workflow naming requirements, move outputs from temporary to permanent storage, and fix parameter handling issues.
Key changes:
- Add required workflow names to CPG-Flow invocations
- Move AnnotateCohort output from temporary to permanent storage
- Fix combiner stage parameter handling to prevent accidental re-runs
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/cpg_seqr_loader/stages.py | Updated combiner temp directory handling and moved AnnotateCohort output location |
| src/cpg_seqr_loader/jobs/CombineGvcfsIntoVds.py | Added import and converted string parameter back to Path object |
| src/cpg_seqr_loader/full_workflow.py | Added required workflow name parameter to run_workflow call |
| src/cpg_seqr_loader/first_workflow.py | Added required workflow name parameter to run_workflow call |
| pyproject.toml | Updated version and CPG-Flow dependency requirements |
| README.md | Updated version references in documentation |
| .github/workflows/docker.yaml | Updated version for Docker builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Johnnyassaf
approved these changes
Oct 17, 2025
EddieLF
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
Checklist