Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis stopped running our builds and is demanding money, so bye bye. Sets up builds on CircleCI using the same basic approach, although this runs in multiple steps, in parallel where possible.
Since we now build the Docker image in one step and then sharing it with other steps using Circle’s Workspaces feature, we get significant build time gains by slimming down the Docker image. It turns out we were still installing all of Chrome(!), in support of the no-longer-used Karma test suite. I deleted that and also switched over to the Alpine Linux-based Node base image, which is optimized for small image size.