Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Redux logic errors" #2122

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Conversation

outoftime
Copy link
Contributor

Reverts #1954

Fixes #2121

@outoftime
Copy link
Contributor Author

FWIW I donʼt think #1954 introduced the root cause of the regression—I suspect that an existing problem in the validation code path had more severe user-facing consequences because of differences in error handling between redux-saga and redux-logic. So, the followup here will be to both fix the specific uncaught error (calling toString() on a possibly-nullish value) as well as adding more graceful uncaught error handling to our redux-logic deployment.

@outoftime outoftime merged commit df903da into master Jan 31, 2020
@outoftime outoftime deleted the revert-1954-redux-logic-errors branch January 31, 2020 14:30
@joshling1919 joshling1919 mentioned this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'toString' of undefined
1 participant