Consolidate app initialization logic#2053
Merged
outoftime merged 1 commit intopopcodeorg:masterfrom Jan 2, 2020
Merged
Conversation
outoftime
force-pushed
the
init-outside-workspace
branch
2 times, most recently
from
fcc4ff5 to
ce2617e
Compare
outoftime
force-pushed
the
init-outside-workspace
branch
from
ce2617e to
01cd6ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App initialization logic has historically occurred in two places:
applicationmodule<Workspace>componentThe former is hard to test and not necessarily intuitive; the second is out-of-place since none of the initialization logic is in fact related to the component in question.
So, consolidate all initialization logic into a new index module for the
initpackage; a singleinit()function is now the single entrypoint into initialization. As well as better organization this also made it more practical to write tests for application initialization.