Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Firebase #1741

Merged
merged 6 commits into from
Aug 27, 2019
Merged

Upgrade Firebase #1741

merged 6 commits into from
Aug 27, 2019

Conversation

outoftime
Copy link
Contributor

@outoftime outoftime commented Aug 23, 2019

Upgrades Firebase SDK from version 5.8.6 → 6.4.2. Also goes back to specifying the top-level firebase meta-package as a dependency, rather than the individual package components; this makes it trivial to tell the SDK version by looking at package.json. It does mean we install a few packages we don’t use, but they aren’t included by the runtime; it’s just a slight waste at yarn install time.

6.0.0 did introduce some breaking changes, but none that affect us. It also deprecates some functions that we were using; so, switch to the non-deprecated alternatives.

@outoftime outoftime marked this pull request as ready for review August 27, 2019 23:43
@outoftime outoftime merged commit 2a009e3 into popcodeorg:master Aug 27, 2019
@outoftime outoftime deleted the upgrade-firebase branch August 27, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant