Skip to content

Refactor instructions editor to follow controlled component pattern #1397

Open
@jwang1919

Description

@jwang1919

Currently the instructions editor is an uncontrolled component, which is to say that intermediate in-progress editing state is stored only in the DOM.

React officially recommends using controlled components instead, which stores intermediate state in React (in our case Redux) state, and has the form value mirror the props given. This is probably the right approach here (but maybe it’s not! Further research may be called for).

Probably best not to sweat this too much until #1394 is done (or at least concurrently with that task).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions