Clicking close button multiple times should only result in one signal to be sent

[siddhpant]

Spam-clicking close button in stacked mode causes gnome-shell to crash.

While it's an issue with gnome-shell, the originator is this extension which doesn't handle spam-click properly.

[jacobgkau]

The upstream issue was closed about a week ago, which I think means Pop!_Shell's behavior should no longer trigger a crash (once the fix makes it into a GNOME release).

[siddhpant]

Yes, but it should not have happened in the first place and as of now one can still cause crashes on prod machines.

It's better that the close button function be wrapped in a mutex (or similar, not really familiar with the codebase).

[siddhpant]

Would this work? I'm assuming it isn't multi-threaded:

diff --git a/src/stack.ts b/src/stack.ts
index 60d553bb740b..90be03b589a6 100644
--- a/src/stack.ts
+++ b/src/stack.ts
@@ -91,8 +91,14 @@ const TabButton = GObject.registerClass(
                 }),
             );
 
+           this._running_close = false;
+
             close_button.connect('clicked', () => {
-                window.meta.delete(global.get_current_time());
+               if (!this._running_close) {
+                   this._running_close = true;
+                   window.meta.delete(global.get_current_time());
+                   this._running_close = false;
+               }
             });
 
             close_button.set_x_align(Clutter.ActorAlign.END);