Skip to content

Commit

Permalink
gpio: nuvoton: Fix sgpio irq handle error
Browse files Browse the repository at this point in the history
The generic_handle_domain_irq() function calls irq_resolve_mapping().
Thus delete a duplicative irq_find_mapping() call
so that a stack trace and an RCU stall will be avoided.

Fixes: c4f8457 ("gpio: nuvoton: Add Nuvoton NPCM sgpio driver")
Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240506064244.1645922-1-JJLIU0@nuvoton.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
  • Loading branch information
jimliu3 authored and Bartosz Golaszewski committed May 7, 2024
1 parent 2b5ae9c commit 7f45fe2
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions drivers/gpio/gpio-npcm-sgpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc)
struct gpio_chip *gc = irq_desc_get_handler_data(desc);
struct irq_chip *ic = irq_desc_get_chip(desc);
struct npcm_sgpio *gpio = gpiochip_get_data(gc);
unsigned int i, j, girq;
unsigned int i, j;
unsigned long reg;

chained_irq_enter(ic, desc);
Expand All @@ -443,11 +443,9 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc)
const struct npcm_sgpio_bank *bank = &npcm_sgpio_banks[i];

reg = ioread8(bank_reg(gpio, bank, EVENT_STS));
for_each_set_bit(j, &reg, 8) {
girq = irq_find_mapping(gc->irq.domain,
i * 8 + gpio->nout_sgpio + j);
generic_handle_domain_irq(gc->irq.domain, girq);
}
for_each_set_bit(j, &reg, 8)
generic_handle_domain_irq(gc->irq.domain,
i * 8 + gpio->nout_sgpio + j);
}

chained_irq_exit(ic, desc);
Expand Down

0 comments on commit 7f45fe2

Please sign in to comment.