Regression fix for bounds check bug where images > 2048px could have data missing from the bottom right corner - #321
Merged
Merged
Conversation
Previous behavior: images larger that 2048px would have their bottom right corners transparent because the info didn't get uploaded to the GPU
wash2
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating yesterday to the latest libcosmic widgets for an app I'm working on that deals with photos, I saw that some of my larger photos were missing info from their bottom right corner. Smaller images were all fine, as were thumbnails that I created from the larger images, which was puzzling, because I'd originally thought it was an image decoding problem.
I traced it back to this bounds check that was added in the pop os fork of iced with #296, which it looks like doesn't account for fragments that started on the last row, basically. The change in this patch fixes it for me locally.